Skip to content

New functions to expressions#1209

Merged
framitdavid merged 2 commits intomainfrom
feat/1176_NewSimpleFuncitonsToExpr
May 30, 2023
Merged

New functions to expressions#1209
framitdavid merged 2 commits intomainfrom
feat/1176_NewSimpleFuncitonsToExpr

Conversation

@framitdavid
Copy link
Contributor

@framitdavid framitdavid commented May 30, 2023 •
edited
Loading

Description

Created new functions to be available for expressions, please see the issue for more details.

Working on documentation while this PR is in review.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

68.8% 68.8% Coverage
0.0% 0.0% Duplication

@framitdavid framitdavid added kind/feature-request New feature or request area/logic related to logic/dynamics/expressions labels May 30, 2023
@framitdavid framitdavid marked this pull request as ready for review May 30, 2023 11:13
bjosttveit
bjosttveit reviewed May 30, 2023
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! And great test coverage! Just one question, will expressions using state.textResources or selectedAppLanguage reevaluate if the language changes?

@framitdavid
Copy link
Contributor Author

framitdavid commented May 30, 2023 •
edited
Loading

Very nice! And great test coverage! Just one question, will expressions using state.textResources or selectedAppLanguage reevaluate if the language changes?

@bjosttveit great question!👍 I was testing this by console.log "running language function" inside the language expression and it logs on every language change I did within the app, meaning it re-runs every time I change the language within the app.

@framitdavid framitdavid merged commit cf18723 into main May 30, 2023
@framitdavid framitdavid deleted the feat/1176_NewSimpleFuncitonsToExpr branch May 30, 2023 12:17
@olemartinorg
Copy link
Contributor

olemartinorg commented May 30, 2023

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

@bjosttveit
Copy link
Member

bjosttveit commented May 30, 2023

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

Sorry I should probably have known that 😬

@framitdavid
Copy link
Contributor Author

framitdavid commented May 30, 2023

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

Sorry I should probably have known that 😬

No worries, then we both learned something @bjosttveit. 😄 Thanks to @olemartinorg for catching this quite fast after the merge. I have a PR that should fix this problem. Ready for review: #1214

@framitdavid
Copy link
Contributor Author

framitdavid commented May 30, 2023

Docs PR is ready for review here. Altinn/altinn-studio-docs#946 :)

@olemartinorg olemartinorg mentioned this pull request May 31, 2023
Merged
21 tasks
@bjosttveit bjosttveit added the kind/product-feature Pull requests containing new features label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjosttveit bjosttveit bjosttveit approved these changes

Assignees

No one assigned

Labels

area/logic related to logic/dynamics/expressions kind/feature-request New feature or request kind/product-feature Pull requests containing new features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expressions: New simple functions

3 participants

@framitdavid @olemartinorg @bjosttveit